Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: (Snippets Web Components) Autodocs fix #23442

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jonniebigodes
Copy link
Contributor

Fixed an issue with web component's snippets for autodocs. Up until now they were referencing docsPage when actually it should be autodocs.

@kylegach to get this patched into the documentation, I'm going to self-merge it once the checklist clears. Sounds good?

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 13, 2023
@jonniebigodes jonniebigodes self-assigned this Jul 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Fails
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against 950218f

Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jonniebigodes jonniebigodes merged commit cfcb363 into next Jul 13, 2023
48 of 58 checks passed
@jonniebigodes jonniebigodes deleted the chore_docs_web_snippets_fix branch July 13, 2023 18:04
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
16 tasks
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
11 tasks
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
storybook-bot pushed a commit that referenced this pull request Jul 18, 2023
Docs: (Snippets Web Components) Autodocs fix
(cherry picked from commit cfcb363)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants