Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Don't distribute generic type of Meta and Story #24110

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Sep 8, 2023

Closes #23629

What I did

Make sure to not distribute generic type of Meta and Story, so that unions get preserved.
See #23629

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I have manual tested this with some different TS versions. The error occurs in TS 5.0 but not TS 4.9 (which we use in the monorepo).

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24110-sha-9e9d8374. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24110-sha-9e9d8374
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/fix-types
Commit 9e9d8374
Datetime Fri Sep 8 15:11:18 UTC 2023 (1694185878)
Workflow run 6123416605

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24110

@kasperpeulen kasperpeulen merged commit 22bc762 into next Sep 12, 2023
54 of 60 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-types branch September 12, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using Meta<PropType> is broken when using discriminating types
2 participants