Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Blocks: Remove defaultProps in Stories block #24506

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

WouterK12
Copy link
Contributor

Closes #24305

What I did

Removed the use of defaultProps in Stories.tsx to future proof the component.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

(I think most tests?)

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Create an autodoc page as described in the issue: [Bug]: Support for defaultProps will be removed from function components in a future major release.聽#24305
  2. Observe no console error

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃檹

@JReinhold JReinhold self-assigned this Oct 18, 2023
@JReinhold JReinhold changed the title Remove Stories use defaultProps (#24305) Doc Blocks: Remove defaultProps inStories block Oct 18, 2023
@WouterK12 WouterK12 closed this Oct 18, 2023
@WouterK12
Copy link
Contributor Author

Sorry, closed this by accident

@WouterK12 WouterK12 reopened this Oct 18, 2023
@WouterK12 WouterK12 changed the title Doc Blocks: Remove defaultProps inStories block Doc Blocks: Remove defaultProps in Stories block Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Support for defaultProps will be removed from function components in a future major release.
2 participants