Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastBuild: Fix disabledAddons filter #24924

Merged
merged 3 commits into from
Nov 22, 2023
Merged

FastBuild: Fix disabledAddons filter #24924

merged 3 commits into from
Nov 22, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Nov 20, 2023

Closes #

Ref: #24837 (comment)

What I did

Fixed a bug which prevented any addons from being loaded in --test mode except addon-coverage and addon-docs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I tested this in my own app a little differently, but I'd recommend trying this:

  1. Build an app that uses a few addons, using --test.
  2. Without this fix, those addons won't be loaded. You might not even get an addons panel.
  3. With this fix, your addons should work fine.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@IanVS
Copy link
Member Author

IanVS commented Nov 21, 2023

I can't tell why yarn install is failing in CI, so I opened #24938 to save off the storybook log and hopefully that will give more info.

@ndelangen ndelangen merged commit 95f02fe into next Nov 22, 2023
59 of 60 checks passed
@ndelangen ndelangen deleted the fix-disabled-addons branch November 22, 2023 08:10
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants