Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed Typo in documentation template #25221

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

Darth-koder007
Copy link
Contributor

@Darth-koder007 Darth-koder007 commented Dec 13, 2023

Removed unused imports from Documentation Template

Closes #

What I did

Fixed Typo on documentation template

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Removed unused imports from Documentation Template
@jonniebigodes jonniebigodes self-assigned this Dec 13, 2023
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Dec 13, 2023
@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 14, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darth-koder007 thanks for taking the time to put together this pull request and helping us improve the documentation, by catching this small but rather import oversight. We appreciate it 🙏 ! I've checked and all is good on my end. Going to merge once the checklist clears.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes merged commit 276af47 into storybookjs:next Dec 14, 2023
16 of 17 checks passed
storybook-bot pushed a commit that referenced this pull request Dec 14, 2023
Docs: Fixed Typo in documentation template
(cherry picked from commit 276af47)
storybook-bot pushed a commit that referenced this pull request Dec 14, 2023
Docs: Fixed Typo in documentation template
(cherry picked from commit 276af47)
@Darth-koder007 Darth-koder007 deleted the patch-1 branch December 15, 2023 06:06
storybook-bot pushed a commit that referenced this pull request Dec 15, 2023
Docs: Fixed Typo in documentation template
(cherry picked from commit 276af47)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants