CLI: Fix regex used in upgrade command #25284
Merged
+64
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
ndelangen,
kasperpeulen and
valentinpalkovic
as code owners
yannbf
force-pushed
the
fix/upgrade-command
branch
2 times, most recently
from
87d7398
to
d3c690c
Compare
yannbf
force-pushed
the
fix/upgrade-command
branch
from
5bdf988
to
6b5d9c7
Compare
valentinpalkovic
approved these changes
Dec 29, 2023
ndelangen
approved these changes
Jan 3, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
When running
npx storybook@next upgrade --prerelease, therejectflag passed ontonpm-check-updateswas incorrect, resulting in an unsuccessful upgrade. However, the code didn't handle the error state, and therefore the upgrade command would continue:This PR both fixes the regex and adds categorized errors to the upgrade CLI command:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No need, it's been thoroughly tested.
path/to/cli/bin/index.js upgrade --prereleaseDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>