Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Fix pre-transform error in Vite 5 #25329

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 27, 2023

Closes #25256

What I did

This PR adds a configuration to vite so that assets handled via Storybook's express server are ignored, therefore resolving the following error:

12:55:22 [vite] Pre-transform error: Failed to load url /sb-preview/runtime.js (resolved id: /sb-preview/runtime.js). Does the file exist?

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25329-sha-028652d7. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-25329-sha-028652d7
Triggered by @yannbf
Repository storybookjs/storybook
Branch yann/pre-transform-error-vite-5
Commit 028652d7
Datetime Wed Dec 27 18:08:34 UTC 2023 (1703700514)
Workflow run 7340795345

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25329

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch builder-vite ci:merged Run the CI jobs that normally run when merged. labels Dec 27, 2023
@yannbf yannbf merged commit aa0b69c into next Dec 28, 2023
71 checks passed
@yannbf yannbf deleted the yann/pre-transform-error-vite-5 branch December 28, 2023 19:52
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
9 tasks
storybook-bot pushed a commit that referenced this pull request Dec 28, 2023
…ite-5

Vite: Fix pre-transform error in Vite 5
(cherry picked from commit aa0b69c)
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
11 tasks
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
…ite-5

Vite: Fix pre-transform error in Vite 5
(cherry picked from commit aa0b69c)
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
…ite-5

Vite: Fix pre-transform error in Vite 5
(cherry picked from commit aa0b69c)
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
…ite-5

Vite: Fix pre-transform error in Vite 5
(cherry picked from commit aa0b69c)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 1, 2024
mbao01 added a commit to mbao01/mbao01 that referenced this pull request Jan 19, 2024
mbao01 added a commit to mbao01/mbao01 that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug builder-vite ci:merged Run the CI jobs that normally run when merged. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vite Pre-transform error: Failed to load url /sb-preview/runtime.js
2 participants