Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automigrations: General fixes for automigrations, blockers and codemods #26210

Merged
merged 21 commits into from
Feb 28, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Feb 27, 2024

Closes N/A

What I did

Enhances the overall experience with codemods and automigrations:

  • Fixed a bug where the wrong link was shown in the migration summary, which pointed to the 7.0 Migration Guide
  • Fixed a bug in the legacy-mdx-1 automigration
  • Clarified the wording in the argtypes-regex automigration
  • Reordered some automigrations
  • Enhanced formatting in autoblocks
  • Smaller typo fixes

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26210-sha-0190219a. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26210-sha-0190219a sandbox or in an existing project with npx storybook@0.0.0-pr-26210-sha-0190219a upgrade.

More information
Published version 0.0.0-pr-26210-sha-0190219a
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/automigration-fixes
Commit 0190219a
Datetime Tue Feb 27 12:43:55 UTC 2024 (1709037835)
Workflow run 8064922662

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26210

@valentinpalkovic valentinpalkovic self-assigned this Feb 27, 2024
Base automatically changed from valentin/enhance-mdx-to-csf-codemod to next February 27, 2024 14:01
@valentinpalkovic valentinpalkovic changed the title General fixes for automigrations, blockers and codemods Automigrations: General fixes for automigrations, blockers and codemods Feb 28, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review February 28, 2024 08:34
@valentinpalkovic valentinpalkovic added this to the 8.0-RC milestone Feb 28, 2024
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but they are nits anyway so you're free to disagree with them.

@valentinpalkovic valentinpalkovic merged commit a010d45 into next Feb 28, 2024
57 of 58 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/automigration-fixes branch February 28, 2024 10:03
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants