Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix number controls do not reset #26372

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

jiyiru
Copy link
Contributor

@jiyiru jiyiru commented Mar 7, 2024

Closes #25819

What I did

Fixed the number controls which didn't reset after clicking on "reset controls" button both in the story button and the docs.
The fix was done by changing the condition that renders the "Set number" button which is what is supposed to happen after clicking in "Reset controls". The condition was changed because one of the elements was never true after resetting controls, so it would never render the "Set number" button.

Showcase.controls.after.resetting.mp4

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run the default sandbox yarn start
  2. Modify Button.tsx (storybook/sandbox/react-vite-default-ts/src/stories/Button.tsx) file to add a new arg of type number called age
    image
  3. Access the page and test if the numbers reset in the age button after clicking on Reset controls

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jiyiru
Copy link
Contributor Author

jiyiru commented Mar 7, 2024

@cdedreuille hello, sorry to bother you. Do you have a minute to review this pr?

@jiyiru jiyiru changed the title Fix number of controls do not reset Fix number controls do not reset Mar 7, 2024
@ndelangen ndelangen self-assigned this Mar 12, 2024
@ndelangen ndelangen changed the title Fix number controls do not reset Controls: Fix number controls do not reset Mar 12, 2024
Copy link

nx-cloud bot commented Mar 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 99969fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen
Copy link
Member

I manually verified with a local test.

@ndelangen ndelangen merged commit 2c00719 into storybookjs:next Mar 12, 2024
44 of 46 checks passed
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
18 tasks
@jiyiru jiyiru deleted the my-first-storybook-contribution branch June 4, 2024 18:48
@jiyiru jiyiru restored the my-first-storybook-contribution branch June 4, 2024 18:49
@jiyiru jiyiru deleted the my-first-storybook-contribution branch June 4, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Number controls do not reset
2 participants