Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automigrations: Fix missing support for mts vite config #26441

Conversation

drik98
Copy link
Contributor

@drik98 drik98 commented Mar 12, 2024

What I did

When migrating to storybook 8.0.0 using pnpm dlx storybook@latest upgrade one of the migration checks said

๐Ÿ”Ž found a 'viteConfigFile' migration:
โ•ญ Migration notification โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฎ
โ”‚                                                                                  โ”‚
โ”‚   Since version 8.0.0, Storybook no longer ships with a Vite config build-in.    โ”‚
โ”‚   Please add a vite.config.js file to your project root.                         โ”‚
โ”‚                                                                                  โ”‚
โ”‚   You can find more information on how to do this here:                          โ”‚
โ”‚   https://storybook.js.org/docs/8.0/migration-guide/#missing-viteconfigjs-file   โ”‚
โ”‚                                                                                  โ”‚
โ”‚   This change was necessary to support newer versions of Vite.                   โ”‚
โ”‚                                                                                  โ”‚
โ•ฐโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ•ฏ

which is wrong because my project does have a vite config file (vite.config.mts) just with a different ending then expected from storybook. Storybook already supports both .mjs and .ts so I just added .mts as well as it is already working even though the message says it does not.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Already worked for me locally anyway.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

๐Ÿฆ‹ Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Mar 12, 2024

โ˜๏ธ Nx Cloud Report

CI is running/has finished running commands for commit 807aaa4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

๐Ÿ“‚ See all runs for this CI Pipeline Execution


โœ… Successfully ran 1 target

Sent with ๐Ÿ’Œ from NxCloud.

@valentinpalkovic valentinpalkovic self-assigned this Mar 12, 2024
@valentinpalkovic valentinpalkovic added bug ci:normal automigrations patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 12, 2024
@valentinpalkovic valentinpalkovic changed the title Fix missing support for mts vite config Automigrations: Fix missing support for mts vite config Mar 12, 2024
Copy link
Contributor

@valentinpalkovic valentinpalkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @drik98 for your contribution!

@drik98
Copy link
Contributor Author

drik98 commented Mar 22, 2024

@valentinpalkovic Will this be merged?

@valentinpalkovic valentinpalkovic added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 22, 2024
@valentinpalkovic
Copy link
Contributor

@drik98 Thank you for the heads up! Merging in progress...

@valentinpalkovic valentinpalkovic merged commit 5e2c5e0 into storybookjs:next Mar 22, 2024
49 of 57 checks passed
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
22 tasks
storybook-bot pushed a commit that referenced this pull request Mar 22, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
9 tasks
storybook-bot pushed a commit that referenced this pull request Mar 24, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
โ€ฆvite-config

Automigrations: Fix missing support for mts vite config
(cherry picked from commit 5e2c5e0)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automigrations bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants