Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add --config-dir flag to add command #26771

Merged
merged 2 commits into from Apr 9, 2024

Conversation

eric-blue
Copy link
Contributor

@eric-blue eric-blue commented Apr 8, 2024

Closes #

What I did

In the spirit of #26721, this PR adds a flag to the add so users can specify the config-dir of their Storybooks.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Apr 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 29078ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@eric-blue
Copy link
Contributor Author

@yannbf

@jonniebigodes
Copy link
Contributor

jonniebigodes commented Apr 9, 2024

@eric-blue, if you're okay with it, can you include a minor adjustment to the documentation so we can include the option once this is approved/merged? Specifically here.

Let me know and we'll take it from there.

Have a fantastic day.

Stay safe

@eric-blue
Copy link
Contributor Author

@jonniebigodes done!

@jonniebigodes
Copy link
Contributor

@eric-blue appreciate you taking the time to make the documentation updates so promptly 🙏 ! From my end is all good, and I'll defer to @valentinpalkovic when to merge this.

@valentinpalkovic valentinpalkovic merged commit c67bf67 into storybookjs:next Apr 9, 2024
46 of 48 checks passed
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants