Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] fix link to preview of viewport addon #2696

Merged
merged 1 commit into from
Jan 9, 2018
Merged

[documentation] fix link to preview of viewport addon #2696

merged 1 commit into from
Jan 9, 2018

Conversation

Kiwka
Copy link
Contributor

@Kiwka Kiwka commented Jan 9, 2018

Issue:

Preview of viewport addon has broken link in documentation for addon

What I did

Fixed link to preview

How to test

Visually in Readme.md file

@Hypnosphi
Copy link
Member

Thanks @Kiwka

@ndelangen shouldn't we use the approach from #2644 for this image as well?

@codecov
Copy link

codecov bot commented Jan 9, 2018

Codecov Report

Merging #2696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2696   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         389      389           
  Lines        8747     8747           
  Branches      909      906    -3     
=======================================
  Hits         3005     3005           
+ Misses       5143     5131   -12     
- Partials      599      611   +12
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/index.js 74.35% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 54.54% <0%> (ø) ⬆️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba66d77...0c85dd7. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 23b18e1 into storybookjs:master Jan 9, 2018
Hypnosphi added a commit that referenced this pull request Feb 12, 2018
[documentation] fix link to preview of viewport addon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants