Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Remove "Ensure next is ahead" script #27121

Merged
merged 2 commits into from
May 14, 2024

Conversation

JReinhold
Copy link
Contributor

What I did

Removef the "Ensure next is ahead" script completely. The point of it was to always ensure that next was ahead of main after any given release, and bump next accordingly if not. It worked fine, eg. when releasing 8.1.0 to main, it bumped next to 8.2.0-alpha.0 as it should.

However this breaks CI on next, saying it can't install that version because it's not published. This is a general problem that we can't workaround.

The solution is to manually release a new preminor right after a minor has been released.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold requested a review from ndelangen May 14, 2024 12:03
@JReinhold JReinhold self-assigned this May 14, 2024
Copy link

nx-cloud bot commented May 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 73823d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:normal labels May 14, 2024
@ndelangen ndelangen merged commit 3a1facb into next May 14, 2024
61 checks passed
@ndelangen ndelangen deleted the jeppe/remove-ensure-next branch May 14, 2024 14:04
@github-actions github-actions bot mentioned this pull request May 14, 2024
17 tasks
JReinhold pushed a commit that referenced this pull request May 15, 2024
Release tooling: Remove "Ensure `next` is ahead" script

(cherry picked from commit 3a1facb)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants