Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Support v18 #27237

Merged
merged 1 commit into from
May 23, 2024
Merged

Angular: Support v18 #27237

merged 1 commit into from
May 23, 2024

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

I have widened the version range of Angular peer dependencies to allow the usage of Angular v18.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this May 23, 2024
@valentinpalkovic valentinpalkovic added feature request angular patch:yes Bugfix & documentation PR that need to be picked to main branch ci:daily Run the CI jobs that normally run in the daily job. labels May 23, 2024
Copy link

nx-cloud bot commented May 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bc3945f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review May 23, 2024 09:04
@valentinpalkovic valentinpalkovic merged commit f2a0cc2 into next May 23, 2024
114 of 127 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/support-angular-18 branch May 23, 2024 09:14
storybook-bot pushed a commit that referenced this pull request May 23, 2024
Angular: Support v18
(cherry picked from commit f2a0cc2)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 23, 2024
sinnedh added a commit to sinnedh/storybook that referenced this pull request Jun 12, 2024
Storybook is now compatible to Angular 18 
(see storybookjs#27237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular ci:daily Run the CI jobs that normally run in the daily job. feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants