Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Ignore git hooks when $SKIP_STORYBOOK_GIT_HOOKS is set #28549

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 11, 2024

What I did

Ignore git hooks when $SKIP_STORYBOOK_GIT_HOOKS is set

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 23.3s 23.8s 494ms 2.1%
generateTime 20.4s 21.6s 1.1s 🔺5.4%
initTime 22.3s 22.2s -75ms -0.3%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 216 B 0%
initSize 205 MB 205 MB 216 B 0%
diffSize 128 MB 128 MB 0 B 0%
buildTime 12.8s 13.2s 422ms 3.2%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 11s 10.9s -94ms -0.9%
devManagerResponsive 6.9s 6.7s -208ms -3.1%
devManagerHeaderVisible 1.1s 1s -113ms 🔰-11.2%
devManagerIndexVisible 1.1s 1s -125ms 🔰-12%
devStoryVisibleUncached 1.6s 1.8s 252ms 🔺13.6%
devStoryVisible 1.1s 1s -117ms 🔰-11%
devAutodocsVisible 961ms 806ms -155ms 🔰-19.2%
devMDXVisible 909ms 826ms -83ms 🔰-10%
buildManagerHeaderVisible 1s 850ms -150ms 🔰-17.6%
buildManagerIndexVisible 1s 852ms -150ms 🔰-17.6%
buildStoryVisible 1s 919ms -147ms 🔰-16%
buildAutodocsVisible 994ms 712ms -282ms 🔰-39.6%
buildMDXVisible 882ms 725ms -157ms 🔰-21.7%

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Jul 11, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Modified /code/package.json to conditionally skip linting in pre-commit hook if SKIP_STORYBOOK_GIT_HOOKS is set
  • Ensure bypass does not lead to unlinted code being committed

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9b4fcbb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit cbf921a into next Jul 12, 2024
6 of 7 checks passed
@kasperpeulen kasperpeulen deleted the kasper/opt-out-git-hooks branch July 12, 2024 14:35
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant