Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Make a few automigrations run on all version upgrades #28601

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 15, 2024

Closes #

What I did

This PR changes a few automigrations so that they always run. We don't know exactly how Storybook users upgrade their versions, so it's possible they still have incorrect setups even when using the latest versions.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 8s 16.5s 8.4s 🔺51.4%
generateTime 24.7s 23.3s -1s -444ms 🔰-6.2%
initTime 25.1s 25.4s 262ms 1%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 0 B 0%
initSize 198 MB 198 MB -304 B 0%
diffSize 121 MB 121 MB -304 B 0%
buildTime 14.9s 18.6s 3.6s 🔺19.7%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 8.8s 7.7s -1s -156ms 🔰-15%
devManagerResponsive 5.7s 4.9s -720ms 🔰-14.4%
devManagerHeaderVisible 813ms 710ms -103ms 🔰-14.5%
devManagerIndexVisible 844ms 745ms -99ms 🔰-13.3%
devStoryVisibleUncached 1.5s 1.2s -305ms 🔰-24.6%
devStoryVisible 872ms 763ms -109ms 🔰-14.3%
devAutodocsVisible 774ms 673ms -101ms 🔰-15%
devMDXVisible 797ms 703ms -94ms 🔰-13.4%
buildManagerHeaderVisible 737ms 770ms 33ms 4.3%
buildManagerIndexVisible 743ms 773ms 30ms 3.9%
buildStoryVisible 787ms 822ms 35ms 4.3%
buildAutodocsVisible 650ms 633ms -17ms -2.7%
buildMDXVisible 670ms 620ms -50ms 🔰-8.1%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • /code/lib/cli/src/automigrate/fixes/addon-postcss.ts: Changed versionRange to always run the addonPostCSS fix.
  • /code/lib/cli/src/automigrate/fixes/addons-api.ts: Modified versionRange to always run the addonsAPI fix.
  • /code/lib/cli/src/automigrate/fixes/sb-binary.ts: Updated versionRange to always run the sbBinary fix.
  • /code/lib/cli/src/automigrate/fixes/sb-scripts.ts: Adjusted versionRange to always run the sbScripts fix.
  • /code/lib/cli/src/automigrate/fixes/wrap-require.ts: Set versionRange to always run the wrapRequire fix.

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2717559. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the yann/change-version-ranges-automigration branch from a15340a to 2717559 Compare July 15, 2024 14:51
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 15, 2024
@yannbf yannbf enabled auto-merge July 15, 2024 15:10
@yannbf yannbf merged commit 4c11838 into next Jul 15, 2024
56 of 57 checks passed
@yannbf yannbf deleted the yann/change-version-ranges-automigration branch July 15, 2024 15:15
storybook-bot pushed a commit that referenced this pull request Jul 15, 2024
…-automigration

CLI: Make a few automigrations run on all version upgrades
(cherry picked from commit 4c11838)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2024
…-automigration

CLI: Make a few automigrations run on all version upgrades
(cherry picked from commit 4c11838)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants