viewport-addon: configure => configureViewport #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaaban088
requested review from
danielduan,
Hypnosphi,
saponifi3d and
usulpro
as code owners
Yes, I think so |
Codecov Report
@@ Coverage Diff @@
## master #3414 +/- ##
=======================================
Coverage 36.69% 36.69%
=======================================
Files 458 458
Lines 10135 10135
Branches 892 887 -5
=======================================
Hits 3719 3719
- Misses 5872 5890 +18
+ Partials 544 526 -18
Continue to review full report at Codecov.
|
mshaaban088
force-pushed
the
master
branch
2 times, most recently
from
922e17d
to
491718c
Compare
igor-dv
approved these changes
Apr 15, 2018
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
configureViewportis more convenient by following a naming convention for addons and to avoid aliasing. (and to make @igor-dv happy 馃槈 )What I did
Added
configureViewportfunction (should we drop the other one as it's an alpha version anyways?)How to test
yarn testIs this testable with Jest or Chromatic screenshots?
Yes
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
Yes
If your answer is yes to any of these, please make sure to include it in your PR.
Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]