Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon info prop options #3428

Merged
merged 7 commits into from Apr 16, 2018

Conversation

binomialstew
Copy link

Issue:

Previously, maxPropsIntoLine had no effect on object or array props, potentially resulting in very long lines in the story source. Now, maxPropsIntoLine affects these in the same way as props, including the correct indentation for each key/value.

@binomialstew
Copy link
Author

binomialstew commented Apr 16, 2018

Tests/snapshots will pass but were broken with latest merge from master. Due to #3427 .

@binomialstew
Copy link
Author

I'm not sure how to tag the PR as was requested. I don't have permission to add a label.

@Hypnosphi
Copy link
Member

@danielduan please remove note about tags from PR template, this is confusing

@Hypnosphi
Copy link
Member

Can you please add a prop with large object to addon info example in official-storybook

@binomialstew
Copy link
Author

@Hypnosphi, definitely. Good idea.

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #3428 into master will increase coverage by 0.15%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3428      +/-   ##
==========================================
+ Coverage   36.74%   36.89%   +0.15%     
==========================================
  Files         459      459              
  Lines       10144    10167      +23     
  Branches      886      889       +3     
==========================================
+ Hits         3727     3751      +24     
+ Misses       5911     5879      -32     
- Partials      506      537      +31
Impacted Files Coverage Δ
addons/info/src/components/Props.js 95.45% <100%> (ø) ⬆️
addons/info/src/components/PropVal.js 93.89% <93.02%> (+2.22%) ⬆️
lib/core/src/server/babel_config.js 71.11% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
.../ui/components/stories_panel/stories_tree/index.js 40% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 49.03% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.42% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 0% <0%> (ø) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cb6c5...6f318f0. Read the comment docs.

@binomialstew
Copy link
Author

In looking at this again, I noticed that truncated prop ellipses weren't broken to the next line. The latest push corrects this and adds the test @Hypnosphi suggested.

@Hypnosphi Hypnosphi merged commit 713e78d into storybookjs:master Apr 16, 2018
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 17, 2018
Hypnosphi added a commit that referenced this pull request May 17, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 17, 2018
@Hypnosphi
Copy link
Member

Released as 3.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants