-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'component' option to @addons/info #3476
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
==========================================
+ Coverage 37.44% 92.5% +55.05%
==========================================
Files 455 6 -449
Lines 10284 40 -10244
Branches 906 2 -904
==========================================
- Hits 3851 37 -3814
+ Misses 5902 2 -5900
+ Partials 531 1 -530 Continue to review full report at Codecov.
|
I would say partially, since the What if the I mainly just have decorated components in mind for this use case, on second thought, I don't this this is actually needed, since in #2893 you can just pass in the undecorated component into the story unless the decorator adds some extra functionality, but propTables can be used to document the undecorated component instead |
You can achieve this by combining it with |
I see! Thanks for clarifying |
Issue:
fixes #2893
What I did
added a
component
option that allows users to specify what component is analyzedUsage:
How to test
Is this testable with Jest or Chromatic screenshots? n/a
Does this need a new example in the kitchen sink apps? y
Does this need an update to the documentation? y
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]