Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Node.js 10 #3536

Closed
wants to merge 1 commit into from
Closed

chore: add Node.js 10 #3536

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

What I did

Add Node.js for CI builds to test the current stable Node.js version.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@DanielRuf
Copy link
Contributor Author

failed during stage 'building site': Deploy directory 'netlify-build' does not exist

It seems there is an issue with the Netlify setup in the last few builds.

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

No commitlint style? So should I label it other: ...?

@DanielRuf
Copy link
Contributor Author

DanielRuf commented May 6, 2018

No commitlint style? So should I label it other: ...?

It seems no one applies this to the PRs / commits so where is the sense in this atm? Some commitlint / commitizen / husky solution should be probably used to enforce this (if --no-verify is not used).

@Hypnosphi
Copy link
Member

Actually teamcity builds are running on node:latest image

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label May 6, 2018
@wuweiweiwu
Copy link
Member

Might have some unintended consequences. #3529

@ndelangen
Copy link
Member

@wuweiweiwu testing in node 10 should not have any side-effects for users.

If I understand @Hypnosphi correctly we are already testing on Node8 on CircleCI and Node10 on TeamCity.


@DanielRuf You may commit with any message you like as long as it's decent. Our release process is mostly manual, but the commit process is beginner friendly.

@DanielRuf
Copy link
Contributor Author

DanielRuf commented May 17, 2018

Actually teamcity builds are running on node:latest image

Sure, but what about Travis. Or what is the difference between running the tests on TeamCity and on Travis?

We use CircleCI, TeamCity and Travis and for me it seems like CircleCI runs the same tasks which are also running on TeamCity.

@ndelangen
Copy link
Member

ndelangen commented May 17, 2018

We run many test on both CircleCI and TeamCity. TeamCity runs some additional tests on examples.
We do not use TravisCI AFAIK.


It seems there is an issue with the Netlify setup in the last few builds.

Indeed, I've been meaning to get to that and fix it for the past few days, haven't gotten around to doing that. The TeamCity example tests are mostly a improved version so it hasn't made top priority on my list.

@ndelangen ndelangen closed this May 23, 2018
@DanielRuf DanielRuf deleted the chore/add-nodejs-10 branch May 23, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants