Storyshots puppeteer images do not match #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When current screenshots do not much with previous ones, we show connection error since `expect` method also throws. Workaround that and also lowercase the error message so it would look like more then other errors Fixes #4036
…-not-match Storyshots puppeteer images do not match
Codecov Report
@@ Coverage Diff @@
## master #4045 +/- ##
==========================================
- Coverage 40.82% 40.82% -0.01%
==========================================
Files 444 444
Lines 5555 5556 +1
Branches 748 748
==========================================
Hits 2268 2268
- Misses 2911 2912 +1
Partials 376 376
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Changes from #4037 by @markelog . Merged it here to check what happens with CircleCI.