Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onDeviceUI] Add ability to render addons in React Native #4381

Merged
merged 103 commits into from
Oct 12, 2018
Merged

[onDeviceUI] Add ability to render addons in React Native #4381

merged 103 commits into from
Oct 12, 2018

Commits on Jul 19, 2018

  1. Reducing the size of the ui.

    @Gongreg
    Gongreg committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    8bf63f5 View commit details
    Browse the repository at this point in the history

  2. Addon scrollview with addon names

    @Gongreg
    Gongreg committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    2a6fe0f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. Updated style, shows addons list with loaded addons.

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    233f369 View commit details
    Browse the repository at this point in the history

  2. Updated status bar, so content would not be drawn below it on android.

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    f745fdb View commit details
    Browse the repository at this point in the history

  3. Added some addons to example.

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    676c110 View commit details
    Browse the repository at this point in the history

  4. Moved out of state

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    dc3b8a4 View commit details
    Browse the repository at this point in the history

  5. Fixed event on android.

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    07b502d View commit details
    Browse the repository at this point in the history

  6. Temporary disabled yellow box.

    @Gongreg
    Gongreg committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    a8af427 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Adding two options for storybook ui: 

    isUIOpen - whether to initially show top bar - default true.
isStoryMenuOpen - should show story menu open by default - default false.
    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    e5ca681 View commit details
    Browse the repository at this point in the history

  2. Creating rn-addons.js file inside generators.

    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    8d31f83 View commit details
    Browse the repository at this point in the history

  3. Removed separate addon store.

    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    838748e View commit details
    Browse the repository at this point in the history

  4. Using active prop.

    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    d62e440 View commit details
    Browse the repository at this point in the history

  5. Rewrote addons wrapper without using modal. 

    We cannot use modal since addons expect to be rendered all the time.
So now we display the wrapper as position absolute and make it 0 0 size when it is not visible.
    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    cd0f98a View commit details
    Browse the repository at this point in the history

  6. Fixing yellow box warnings.

    @Gongreg
    Gongreg committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    20969ec View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Addon window by default is scrollable.

    @Gongreg
    Gongreg committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    21d19c2 View commit details
    Browse the repository at this point in the history

  2. Removed yellow box disabling, cleared up example index.

    @Gongreg
    Gongreg committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    6215c8e View commit details
    Browse the repository at this point in the history

  3. Reverted accidentally deleted line.

    @Gongreg
    Gongreg committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    33c99ab View commit details
    Browse the repository at this point in the history

  4. Updated dependencies.

    @Gongreg
    Gongreg committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    40007cf View commit details
    Browse the repository at this point in the history

  5. Dependency bump

    @Gongreg
    Gongreg committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    5a9e6ff View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Updated UI. Removed modal, displaying menus as panels appearing from … 

    …sides.
    @Gongreg
    Gongreg committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    15f48af View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Clearing up the style a little bit.

    @Gongreg
    Gongreg committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ab3cacd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. fixed merge conflict

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    882cf00 View commit details
    Browse the repository at this point in the history

  2. Temporary disabling some examples

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    1fca1dc View commit details
    Browse the repository at this point in the history

  3. Updating the readmes.

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e383470 View commit details
    Browse the repository at this point in the history

  4. Updating the readme.

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    05c96f0 View commit details
    Browse the repository at this point in the history

  5. Added notes addon that support rn

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    cd957da View commit details
    Browse the repository at this point in the history

  6. Updated addon documentation regarding setTimeout.

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    b1d1d5f View commit details
    Browse the repository at this point in the history

  7. Fixed proptypes issue, properly set initial tab from the props.

    @Gongreg
    Gongreg committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    ff66452 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Reduced the amount of rerenders, if you use onDeviceUI it only listen… 

    …s to story change events once instead of twice.
    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    9722c17 View commit details
    Browse the repository at this point in the history

  2. Adding more addons.

    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    dd1fc34 View commit details
    Browse the repository at this point in the history

  3. OnDeviceUI is now set to true by default.

    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    066801d View commit details
    Browse the repository at this point in the history

  4. Updated the notes addon so it renders markdown properly.

    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    f59a64f View commit details
    Browse the repository at this point in the history

  5. Fixes endless cycle when initially rendering when both onDeviceUI and… 

    … server are enabled.
    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    a8db10a View commit details
    Browse the repository at this point in the history

  6. Selection prop is not required ( it is not set when not using onDevic… 

    …eUI).
    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    94f7df1 View commit details
    Browse the repository at this point in the history

  7. Renamed rn-notes to ondevice-notes addon.

    @Gongreg
    Gongreg committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    02057e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2018

  1. Added option to use channels as async.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    68fe8a9 View commit details
    Browse the repository at this point in the history

  2. Using async channel if onDeviceUI is set to true.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    409de89 View commit details
    Browse the repository at this point in the history

  3. Updated notes documentation/tests.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    c0fac41 View commit details
    Browse the repository at this point in the history

  4. Adding backgrounds addon.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    ce55c96 View commit details
    Browse the repository at this point in the history

  5. Updated notes readme.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    ab8dc32 View commit details
    Browse the repository at this point in the history

  6. Adding ondevice knobs addon.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    2d8dfec View commit details
    Browse the repository at this point in the history

  7. Updated example

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    5dd635c View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into rn-storybook-new-ui

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    119b3d1 View commit details
    Browse the repository at this point in the history

  9. Reverted accidental merge issue.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    080e86c View commit details
    Browse the repository at this point in the history

  10. Updating documentation.

    @Gongreg
    Gongreg committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    7400136 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. Fixed knobs entry file.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    3cb9eea View commit details
    Browse the repository at this point in the history

  2. Updating documentation.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    ac8628b View commit details
    Browse the repository at this point in the history

  3. Updating documentation.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    8ea2c5e View commit details
    Browse the repository at this point in the history

  4. Removed packager completely.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    bc33f26 View commit details
    Browse the repository at this point in the history

  5. Updated cli.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    50d2a95 View commit details
    Browse the repository at this point in the history

  6. Added missing dependency.

    @Gongreg
    Gongreg committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    5bd522f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Websocket doesn't throw red screen on connection fail anymore.

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    75ac400 View commit details
    Browse the repository at this point in the history

  2. Takes children from props instead out of state..

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    53df36c View commit details
    Browse the repository at this point in the history

  3. Fixed bug where selecting story didn't actually select it.

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    42d23f8 View commit details
    Browse the repository at this point in the history

  4. Removed ondeviceUI in example.

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    828c80f View commit details
    Browse the repository at this point in the history

  5. If it fails to connect it selects initial story.

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d0fb7e6 View commit details
    Browse the repository at this point in the history

  6. Knobs are properly reset on change.

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    c692813 View commit details
    Browse the repository at this point in the history

  7. Proper import in example

    @Gongreg
    Gongreg committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    708347f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Reverts to localhost if no host is defined.

    @Gongreg
    Gongreg committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    2677250 View commit details
    Browse the repository at this point in the history

  2. Ui doesnt jump when hiding bottom bar, should handle keyboard correct… 

    …ly on ios.
    @Gongreg
    Gongreg committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    65063d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. Updated background addon to unregister on unmount.

    @Gongreg
    Gongreg committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    495670f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2018

  1. Properly handles animations on android.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    8aa8e72 View commit details
    Browse the repository at this point in the history

  2. Creates channel as soon as getStorybookUI is called instead of during… 

    … the render.
    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    69f8448 View commit details
    Browse the repository at this point in the history

  3. Displays message if no addons are loaded.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    7e98e1d View commit details
    Browse the repository at this point in the history

  4. setOptions called without timeout.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    5ab26de View commit details
    Browse the repository at this point in the history

  5. Sets initial story if connection to websocket server fail.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    19b5091 View commit details
    Browse the repository at this point in the history

  6. Updating style.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    11bf337 View commit details
    Browse the repository at this point in the history

  7. Removed margin bottom.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    1aeccd0 View commit details
    Browse the repository at this point in the history

  8. Added swiping on the nav bar, touching preview maximizes it.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    2eccce4 View commit details
    Browse the repository at this point in the history

  9. Fixed keyboard aware view.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    08b2df5 View commit details
    Browse the repository at this point in the history

  10. Fixed background panel so it doesn't lose color immediately.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    bd57fe7 View commit details
    Browse the repository at this point in the history

  11. Uses preview width for panels.

    @Gongreg
    Gongreg committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    8e210ca View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Merge master.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    54b377c View commit details
    Browse the repository at this point in the history

  2. Moving class inside preview.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    2fbd755 View commit details
    Browse the repository at this point in the history

  3. All react native installations receive same template.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    ceee056 View commit details
    Browse the repository at this point in the history

  4. Removed react_native fixture.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    e8c8d83 View commit details
    Browse the repository at this point in the history

  5. Fixing lint.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    4a2b64d View commit details
    Browse the repository at this point in the history

  6. Lint fix.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    c0ff8fe View commit details
    Browse the repository at this point in the history

  7. Improving performance dramatically.

    @Gongreg
    Gongreg committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    44bb6cb View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Merge remote-tracking branch 'origin/master' into rn-storybook-new-ui 

    # Conflicts:
#	app/react-native/readme.md
#	app/react-native/src/bin/storybook-start.js
    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    8e255f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'addons-async-option' into rn-storybook-new-ui

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    11e8f87 View commit details
    Browse the repository at this point in the history

  3. Adding on device addons.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    048b2b4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'on-device-addons' into rn-storybook-new-ui

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    4012044 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'addons-async-option' into on-device-ui-all-prs

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    edfaa09 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'react-native-cli-template' into on-device-ui-all-prs

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    6db1f75 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'react-native-cli-template' into rn-storybook-new-ui 

    # Conflicts:
#	lib/cli/lib/initiate.js
    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    7d98112 View commit details
    Browse the repository at this point in the history

  8. Reverted back fixtures change.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    fb68670 View commit details
    Browse the repository at this point in the history

  9. Reverting file change

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    75cabdf View commit details
    Browse the repository at this point in the history

  10. Merge branch 'on-device-ui-all-prs' into rn-storybook-new-ui

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    667785a View commit details
    Browse the repository at this point in the history

  11. Updating readmes.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    f622a08 View commit details
    Browse the repository at this point in the history

  12. Updated readme about server.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    30d0fd2 View commit details
    Browse the repository at this point in the history

  13. Reverted yarn.lock

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    afe1b5f View commit details
    Browse the repository at this point in the history

  14. Fixing propTypes.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    85e8742 View commit details
    Browse the repository at this point in the history

  15. Splitting out onDeviceUI/index to smaller components.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    8eba6b2 View commit details
    Browse the repository at this point in the history

  16. Splitting up onDeviceUI.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    748a9c9 View commit details
    Browse the repository at this point in the history

  17. Removed unused dependency.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2adbce8 View commit details
    Browse the repository at this point in the history

  18. Properly uses whole screen for preview.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    755f552 View commit details
    Browse the repository at this point in the history

  19. Updated visibility button.

    @Gongreg
    Gongreg committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    36bd66d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Few code review fixes 

    Updated readme,
Renamed handlers.
    @Gongreg
    Gongreg committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    18fccca View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Merge pull request #3903 from storybooks/rn-storybook-new-ui 

    [onDeviceUI] Add ability to render addons in React Native
    @ndelangen
    ndelangen committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    d32952d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2018

  1. Fixed where width is taken from.

    @Gongreg
    Gongreg committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    4499cb5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4379 from storybooks/rn-storybook-new-ui 

    Fixed where width is taken from.
    @Gongreg
    Gongreg committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    d5387d9 View commit details
    Browse the repository at this point in the history

  3. Merge master

    @Gongreg
    Gongreg committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    90f2d48 View commit details
    Browse the repository at this point in the history