Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make tags optional in TestRunnerConfig #391

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Nov 16, 2023

The new tags option in the TestRunnerConfig is currently required and each property is also required. This results in the developer having to include all of it, even when not used.

{
	tags: {
		include: [],
		exclude: [],
		skip: [],
	},
},

This PR makes it optional and does not require all properties, allowing for only used properties to be defined.

{
	tags: {
		exclude: ['design'],
	},
},

Version

Published prerelease version: v0.15.1-next.0

Changelog

🐛 Bug Fix

  • fix: Make tags optional in TestRunnerConfig #391 (@stramel)

Authors: 1

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (449be19) 80.64% compared to head (6541350) 80.64%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #391   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          12       12           
  Lines         217      217           
  Branches       56       56           
=======================================
  Hits          175      175           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this!

@yannbf yannbf added the patch Increment the patch version when merged label Nov 16, 2023
@yannbf yannbf merged commit d2665d1 into storybookjs:next Nov 16, 2023
8 checks passed
@yannbf yannbf mentioned this pull request Nov 16, 2023
Copy link

🚀 PR was released in v0.15.1 🚀

@stramel stramel deleted the patch-2 branch November 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants