Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap storybook/jest to storybook/test #427

Merged
merged 2 commits into from Jan 23, 2024
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 23, 2024

replace @storybook/jest with @storybook/test.

a single letter can make a big difference.

@ndelangen ndelangen self-assigned this Jan 23, 2024
@ndelangen ndelangen added patch Increment the patch version when merged maintenance labels Jan 23, 2024
@yannbf yannbf added skip-release Preserve the current version when merged and removed patch Increment the patch version when merged labels Jan 23, 2024
Copy link

socket-security bot commented Jan 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@storybook/test@7.6.10, npm/check-error@1.0.3, npm/loupe@2.3.7, npm/pathval@1.1.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ndelangen
Copy link
Member Author

@SocketSecurity ignore npm/pathval@1.1.1
@SocketSecurity ignore npm/check-error@1.0.3
@SocketSecurity ignore npm/loupe@2.3.7
@SocketSecurity ignore npm/@storybook/test@7.6.10

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc70b67) 93.77% compared to head (391945d) 93.77%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #427   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          15       15           
  Lines         273      273           
  Branches       71       71           
=======================================
  Hits          256      256           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
yannbf
yannbf previously requested changes Jan 23, 2024
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ndelangen ndelangen requested a review from yannbf January 23, 2024 15:08
@ndelangen ndelangen dismissed yannbf’s stale review January 23, 2024 15:16

fixed all issues

@ndelangen ndelangen merged commit 52487fc into next Jan 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance prerelease skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants