Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add remark regarding pnp support #432

Merged
merged 1 commit into from Jan 31, 2024
Merged

Docs: Add remark regarding pnp support #432

merged 1 commit into from Jan 31, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 31, 2024

Closes storybookjs/storybook#23654

What I did

This PR adds a remark regarding usage of the test-runner and PnP mode, assisting users to fix issues that might arise

Checklist for Contributors

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes in this repository
  • Request documentation updates in the test-runner docs website

Checklist for Maintainers

  • Make sure this PR contains one of the labels below:

    Available labels
    • skip-release: Skip any releases, e.g., documentation only changes, CI config etc.
    • patch: Upgrade patch version (e.g. 0.0.x)
    • minor: Upgrade patch version (e.g. 0.x.0)
    • major: Upgrade patch version (e.g. x.0.0)

@yannbf yannbf added documentation Changes only affect the documentation skip-release Preserve the current version when merged labels Jan 31, 2024
@yannbf
Copy link
Member Author

yannbf commented Jan 31, 2024

@jonniebigodes you might be interested in this

@yannbf yannbf merged commit b83d6ac into next Jan 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: test-storybook fails when using yarn pnp
1 participant