Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning if you try and run against a lazy-compiled storybook #90

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Apr 10, 2022

We want to look into actually working around this problem, but in the meantime, hopefully this will point folks in the right direction.

πŸ“¦ Published PR as canary version: 0.0.6-canary.90.afeeaef.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.6-canary.90.afeeaef.0
# or 
yarn add @storybook/test-runner@0.0.6-canary.90.afeeaef.0

Version

Published prerelease version: v0.0.6-next.0

Changelog

πŸ› Bug Fix

  • Log a warning if you try and run against a lazy-compiled storybook #90 (@tmeasday)

Authors: 1

@tmeasday tmeasday requested a review from yannbf April 10, 2022 06:48
bin/test-storybook.js Outdated Show resolved Hide resolved
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! We might need to setup lint-staged in the repo to avoid formatting inconsistencies πŸ™‰ I'll do that

Co-authored-by: Yann Braga <yannbf@gmail.com>
@tmeasday tmeasday merged commit 99fd8e8 into next Apr 12, 2022
@tmeasday tmeasday deleted the tom/sb-241-log-warning-from-the-test-runner-if-lc branch April 12, 2022 04:01
@yannbf yannbf mentioned this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants