This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
feat: add React18 to peerDeps #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ndelangen
approved these changes
Apr 19, 2022
ndelangen
reviewed
Apr 19, 2022
| @@ -78,7 +78,7 @@ | |||
| "@storybook/client-api": ">=6.4.0", | |||
| "@storybook/preview-web": ">=6.4.0", | |||
| "@storybook/react": ">=6.4.0", | |||
| "react": "^16.8.0 || ^17.0.0" | |||
There was a problem hiding this comment.
Yeah this looks like the proper fix to me.
I'd expect a lock-file change associated with this, @yannbf
if for testing purposes you want to stay on a particular version in this repository (whilst support any listed version) it's a good idea to add the exact version you know this repo is ran with as a devDependency too.
There was a problem hiding this comment.
@ndelangen 👋 Just in case, I just ran yarn install locally and I didn't get any changes on my yarn.lock file.
|
Hi @ndelangen do you know when is this expected to be released? |
|
Yeah I'd assume so, @alejandronanez ? |
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Probably closes #99
What Changed
Add React18 to the peerDependency list
Checklist
Check the ones applicable to your change:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor