This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
fix: Remove deep import StoryFnReactReturnType from @storybook/react #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ljcl, thanks for your contribution! The types should still be there, but maybe from a different path. Regardless, I think it's a good idea. Having react as peer dep also makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the import path used for
StoryFnReactReturnTypeno longer exists in@storybook/reactfrom6.2and onwards.This is causing a type error when used externally.
As this type is only
ReactElement<unknown>I thought it would be better to inline this and avoid a deep import.