Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update TS information #33

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Update TS information #33

merged 1 commit into from
Jun 24, 2021

Conversation

eric-burel
Copy link
Contributor

@eric-burel eric-burel commented Jun 24, 2021

📦 Published PR as canary version: 0.0.18--canary.33.6e6a4b1.0

✨ Test out this PR locally via:

npm install @storybook/testing-react@0.0.18--canary.33.6e6a4b1.0
# or 
yarn add @storybook/testing-react@0.0.18--canary.33.6e6a4b1.0

@yannbf yannbf merged commit c7149ab into main Jun 24, 2021
@yannbf yannbf deleted the eric-burel-patch-2 branch June 24, 2021 20:45
@yannbf
Copy link
Member

yannbf commented Jun 24, 2021

Thanks a lot @eric-burel !

@eric-burel
Copy link
Contributor Author

I just change json to jsonc for the codeblock display (I have write rights on Storybook project so I'll simply commit on main branch to avoid back and forth PR)

@yannbf
Copy link
Member

yannbf commented Jun 25, 2021

I just change json to jsonc for the codeblock display (I have write rights on Storybook project so I'll simply commit on main branch to avoid back and forth PR)

Oh, please don't do that. I always try to avoid pushing directly to main, and now that small change actually made a release with no actual feature or fix. Next time add [skip ci] to the commit message at least :D

@yannbf
Copy link
Member

yannbf commented Jun 25, 2021

Also for some reason the version bump after your push was done by https://github.com/saurabhsahu-tcs. That's pretty odd.

@eric-burel
Copy link
Contributor Author

Ah man I'm dumb I should have expected that sorry! (first time contributing to a project this big)

@yannbf
Copy link
Member

yannbf commented Jun 25, 2021

Ah man I'm dumb I should have expected that sorry! (first time contributing to a project this big)

It's all ok! The change was quite simple and won't impact people anyway. But rule of thumb, never push to main unless you really understand the landscape of the project and you're clearly communicating with the maintainers. It's super fine to make extra PRs for typos!

Thanks for using the lib and for your contributions :))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants