Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export storybook middleware #211

Merged
merged 1 commit into from
May 25, 2016
Merged

Export storybook middleware #211

merged 1 commit into from
May 25, 2016

Conversation

thani-sh
Copy link
Contributor

@thani-sh thani-sh commented May 24, 2016

It'll be much easier to integrate storybook into existing systems for users if storybook is available as an express middleware. This issue is an example use case.

@thani-sh thani-sh force-pushed the storybook-mw branch 2 times, most recently from 4cb20a9 to 54422a9 Compare May 24, 2016 13:31
@arunoda
Copy link
Member

arunoda commented May 25, 2016

Since this is just the our same logic. I think we can proceed with this.

And also, building storybook also works fine.
I am good with this. Merge and make a release.

@thani-sh thani-sh merged commit 52a019a into master May 25, 2016
@thani-sh thani-sh deleted the storybook-mw branch May 25, 2016 07:39
@ericclemmons
Copy link
Contributor

I'm not sure best to import this. require("@kadira/storybook/dist/server/middleware").default seems kinda brittle, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants