Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding airbnb-js-shims again. #419

Merged
merged 1 commit into from Sep 3, 2016
Merged

Adding airbnb-js-shims again. #419

merged 1 commit into from Sep 3, 2016

Conversation

arunoda
Copy link
Member

@arunoda arunoda commented Sep 3, 2016

Issue #400 is only related to a Chrome thing.
So, it's fine to use where the standards lie.

Issue #400 is only related to a Chrome thing.
So, it's fine to use where the standards lie.
@arunoda arunoda merged commit 82086b0 into master Sep 3, 2016
@arunoda arunoda deleted the back-2-airbnb-js-shims branch September 3, 2016 01:09
@arunoda
Copy link
Member Author

arunoda commented Sep 3, 2016

@ljharb check the latest release. It has airbnb-js-shims now.

@ljharb
Copy link
Contributor

ljharb commented Sep 3, 2016

Thanks, much obliged!

@ljharb
Copy link
Contributor

ljharb commented Sep 3, 2016

@arunoda what is babel-polyfill used for? that also pulls in core-js.

@arunoda
Copy link
Member Author

arunoda commented Sep 3, 2016

Yep. But we have disabled polyfills and helpers when transforming.
What did you mean?

@ljharb
Copy link
Contributor

ljharb commented Sep 3, 2016

Then shouldn't it not be a dependency?

@arunoda
Copy link
Member Author

arunoda commented Sep 3, 2016

@ljharb Yep. I think we can remove that altogether.

@ljharb
Copy link
Contributor

ljharb commented Sep 4, 2016

Thanks, that'd be great :-)

@arunoda
Copy link
Member Author

arunoda commented Sep 4, 2016

Removed and did a new release: v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants