Add a search bar to filter components #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| placeholder="Filter" | ||
| name="filter-text" | ||
| value={this.state.filterText} | ||
| onChange={this.filterStoryList.bind(this)} |
There was a problem hiding this comment.
Accept these events via props in the component you create as mentioned above.
There was a problem hiding this comment.
do this.filterStoryList=this.filterStoryList.bind(this) in the constructor . Here it will create a different listener on every re-render.
There was a problem hiding this comment.
Actually, that's fine for specially this kind of apps since we won't render items in often. (Often means few times a sec)
And js.bind is pretty fast and React does a lot more costly stuff for virtual DOM diffing.
roonyh
force-pushed
the
search-bar
branch
2 times, most recently
from
3a71383
to
572e685
Compare
| @@ -0,0 +1,73 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export default class FilterText extends React.Component { | |||
There was a problem hiding this comment.
Always use a noun for the Class name. TextFilter would be a better name.
And make sure file name matches that too. (text_filter.js)
|
Thanks @roonyh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.