Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: website: links to "Made for" sections point to 404 errors #5994

Closed
d2s opened this issue Mar 10, 2019 · 2 comments
Closed

docs: website: links to "Made for" sections point to 404 errors #5994

d2s opened this issue Mar 10, 2019 · 2 comments

Comments

@d2s
Copy link

d2s commented Mar 10, 2019

Describe the bug
Links to "Made for" sections on the front page of the Storybook website https://storybook.js.org/ point to a missing documentation pages (even while those pages exist on other URL addresses).

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Storybook website' https://storybook.js.org/
    2a. Click on 'Made for … HTML' link on the right side of the page (on larger screens)
    2b. Click on 'Made for … Svelte' link on the right side of the page (on larger screens)
    3a. Link points to URL: https://storybook.js.org/basics/guide-html/
    3b. Link points to URL: https://storybook.js.org/basics/guide-svelte/
  2. See error: 404 - Yikes, this is embarassing - Try double-checking the link or going back.

Expected behavior
Expected links to point towards a working page address:
https://storybook.js.org/docs/guides/guide-html/
https://storybook.js.org/docs/guides/guide-svelte/

Screenshots
On the main page of the Storybook website:
2019-03-09-Storybook-website-broken-link-404

Code snippets
Potentially related snippets on the Storybook codebase:

https://github.com/storybooks/storybook/blob/953c43bec6e5ecf09689d1d86fcc01fee5eb11f4/docs/src/new-components/basics/shared/site.js#L74-L75

https://github.com/storybooks/storybook/blob/953c43bec6e5ecf09689d1d86fcc01fee5eb11f4/docs/gatsby-config.js#L16-L26

It might be that those two pages would need to be added to the docs/gatsby-config.js file.

        '/guides/guide-html/',
        '/guides/guide-svelte/',

System:

  • OS: Windows10
  • Device: Desktop
  • Browser: Chrome-based browser
  • Framework: not relevant for this issue
  • Addons: not relevant for this issue
  • Version: 5.0.0 (website)
@shilman
Copy link
Member

shilman commented Mar 10, 2019

@d2s Thanks for the report! It's strange -- I couldn't reproduce the behavior since the site was redirecting properly for me. Nevertheless I've updated the URLs in the docs site and also in the frontpage marketing site, so hopefully it should be fixed now. Can you give it another try?

@d2s
Copy link
Author

d2s commented Mar 10, 2019

@shilman Yes, I thought it could be an issue with redirects. Generally it is a good idea to avoid adding the extra HTTP redirect step to the requests, as it slows down the page performance (even without having this kind of potential issues).

Thank you for the good tool. Lets make it even better, step by step. 😄

@shilman shilman added this to the 5.0.x milestone Mar 10, 2019
@shilman shilman closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants