Add tests for CLI #1767

Hypnosphi · 2017-08-30T00:54:49Z

How to test

yarn bootstrap -- --core
yarn test:cli
yarn bootstrap -- --reset --core
nvm use 4
yarn test:cli

Add fixtures for all supported project types
Automatically update CRA/CRNA fixtures before each test
Support node v4 (see Meteor 1.5 getstorybook error Block-scoped declarations (let, const, function, class) not yet supported outside strict mode #1466)
Run node v4 and v6 tests on CI (help needed, see below)
Use snapshots
Add smoke tests for start-storybook (depends on Add smoke-test option to start-storybook commands #1790)
Integrate tests for CLI into CLI for tests

Hypnosphi · 2017-08-30T00:58:59Z

Speaking of node 4/6 testing on CI, the trick is that we should bootstrap with node 8 (as it's the version we support for contributing), and then run tests with an older version. I tried to use some docker images with nvm, but had no success in that (see for instance https://circleci.com/gh/storybooks/storybook/9091).

codecov · 2017-08-30T01:02:56Z

Codecov Report

Merging #1767 into release/3.3 will decrease coverage by 0.85%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           release/3.3    #1767      +/-   ##
===============================================
- Coverage        23.32%   22.46%   -0.86%     
===============================================
  Files              281      321      +40     
  Lines             6045     6276     +231     
  Branches           706      789      +83     
===============================================
  Hits              1410     1410              
- Misses            4127     4269     +142     
- Partials           508      597      +89

Impacted Files	Coverage Δ
lib/cli/test/snapshots/react_native/index.ios.js	`0% <0%> (ø)`
...react_native/storybook/stories/CenterView/style.js	`0% <0%> (ø)`
lib/cli/lib/has_yarn.js	`0% <0%> (ø)`	⬆️
...test/snapshots/react_native/storybook/storybook.js	`0% <0%> (ø)`
lib/cli/test/fixtures/meteor/client/main.js	`0% <0%> (ø)`
lib/cli/lib/detect.js	`0% <0%> (ø)`	⬆️
lib/cli/test/fixtures/sfc_vue/src/main.js	`0% <0%> (ø)`
...ib/cli/test/fixtures/react_native/index.android.js	`0% <0%> (ø)`
...already_has_storybook/src/registerServiceWorker.js	`0% <0%> (ø)`
...t_native/storybook/stories/Button/index.android.js	`0% <0%> (ø)`
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8052c61...dad58b0. Read the comment docs.

Hypnosphi · 2017-08-30T01:04:01Z

lib/cli/lib/.babelrc

-      "regenerator": true
-    }]
-  ]
-}


I believe this file was added by mistake: https://github.com/storybooks/storybook/pull/911/files#diff-c2e6a73df4341abfc1cce840a8008e9e

ndelangen · 2017-08-30T18:48:09Z

Why do we have to test on older node versions?

Hypnosphi · 2017-08-30T19:34:14Z

How about because node 4 is maintained until April 2018?

# Conflicts: # yarn.lock

# Conflicts: # package.json # yarn.lock

ndelangen · 2017-09-06T07:41:37Z

lib/cli/package.json

  },
  "repository": {
    "type": "git",
    "url": "https://github.com/storybooks/storybook.git"
  },
  "scripts": {
+    "pretest": "cd test && ./update_fixtures.sh",


Can we set this up so this is a jest project, like how the examples/react-native-vanilla is set up?

This would allow running the tests along with all the other unit tests!

I'll take a look

all the other unit tests!

These tests are not unit, they're end-to-end =)

ndelangen · 2017-09-06T07:42:15Z

lib/cli/package.json

+  },
+  "devDependencies": {
+    "check-node-version": "2.1.0",
+    "npx": "9.6.0"


Is this used anywhere within our code? I can't find it in this diff.

Yes, for running fresh CR(N)A without installing globally (yarn create unfortunately does the global install): https://github.com/storybooks/storybook/blob/cac45b496463180d957780d5ca0a142321658626/lib/cli/test/update_fixtures.sh#L14

ndelangen · 2017-09-06T07:46:19Z

lib/cli/test/run_tests.sh

@@ -0,0 +1,41 @@
+#!/bin/bash


This runs tests?
I don't understand what's going on here.

Can't we write jest tests and run them in jest?

If this needs to be this way, we need a good documentation on what this code does, either in a readme.md or above code.

Yes we can, but it's much easier to do those manipulations in bash then in js, plus it's straightforward to reproduce particular steps: you just copypaste them to your console. My inspiration were CRA's e2e tests: https://github.com/facebookincubator/create-react-app/tree/master/tasks

I have added a section to CONTRIBUTING.md, and some inline comments here

Hypnosphi · 2017-09-08T23:42:50Z

I think the rest can be addressed in separate PRs

# Conflicts: # package.json # yarn.lock

Hypnosphi added 8 commits August 30, 2017 02:47

Add tests for CLI. Support node 4

7df5a6a

Skip CRNA for node 4

6798614

Fix ci config

9ef4625

Fix ci config

f81287e

Fix ci config

0110e18

Fix ci config

2497aef

Give up on trying to set up older node versions testing on CI

d68dc9f

Use npx instead of yarn create

10cc95e

Hypnosphi changed the base branch from master to release/3.3 August 30, 2017 00:55

Hypnosphi commented Aug 30, 2017

View reviewed changes

Hypnosphi added cli help wanted maintenance User-facing maintenance tasks labels Aug 30, 2017

Hypnosphi and others added 6 commits September 1, 2017 02:26

Merge branch 'release/3.3' into cli-tests

5844bcd

Merge branch 'release/3.3' into cli-tests

66aca44

# Conflicts: # yarn.lock

merge

29e6d5f

Add snapshot testing

a743158

Use docker-node-rsync image

71e37dc

Run prettier

6826ce0

Hypnosphi mentioned this pull request Sep 3, 2017

Add smoke-test option to start-storybook commands #1790

Closed

Hypnosphi and others added 6 commits September 4, 2017 01:59

Integrate CLI tests into tests CLI

a3e8230

Update CI command

ffa77ff

Merge branch 'release/3.3' into cli-tests

9e48575

Merge remote-tracking branch 'upstream/release/3.3' into cli-tests

15ea4cb

# Conflicts: # package.json # yarn.lock

Update lockfile

340c150

Merge remote-tracking branch 'upstream/cli-tests' into cli-tests

cac45b4

ndelangen requested changes Sep 6, 2017

View reviewed changes

Hypnosphi and others added 4 commits September 8, 2017 01:44

Merge release/3.3

e91d60e

Run smoke tests (disabled for now). Add docs and clarifying comments

2d01afc

Stop running update_fixtures automatically to prevent noisy diffs

e5860f5

Merge branch 'release/3.3' into cli-tests

d84a10b

ndelangen approved these changes Sep 8, 2017

View reviewed changes

Hypnosphi added 4 commits September 9, 2017 03:04

Merge remote-tracking branch 'upstream/release/3.3' into cli-tests

5afe9e5

# Conflicts: # package.json # yarn.lock

Use yarn options passthrough

d417f09

CI: Add "Install latest yarn version" step to cli test jobs

c7fad6c

CI: Add environment to cli test jobs

dad58b0

Hypnosphi merged commit 5e78851 into release/3.3 Sep 9, 2017

Hypnosphi deleted the cli-tests branch September 9, 2017 00:33

Hypnosphi mentioned this pull request Sep 9, 2017

Better handling of undetected project types #1647

Closed

This was referenced Nov 2, 2017

Do a proper full test of CLI in CI #1746

Closed

Meteor 1.5 getstorybook error Block-scoped declarations (let, const, function, class) not yet supported outside strict mode #1466

Closed

dependencies bot mentioned this pull request Feb 16, 2018

Update 25 dependencies from npm #3003

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for CLI #1767

Add tests for CLI #1767

Hypnosphi commented Aug 30, 2017 •

edited

Loading

Hypnosphi commented Aug 30, 2017

codecov bot commented Aug 30, 2017 •

edited

Loading

Hypnosphi Aug 30, 2017

ndelangen commented Aug 30, 2017

Hypnosphi commented Aug 30, 2017

ndelangen Sep 6, 2017

Hypnosphi Sep 6, 2017

Hypnosphi Sep 8, 2017 •

edited

Loading

ndelangen Sep 6, 2017

Hypnosphi Sep 6, 2017

ndelangen Sep 6, 2017

ndelangen Sep 6, 2017

Hypnosphi Sep 6, 2017

Hypnosphi Sep 8, 2017 •

edited

Loading

Hypnosphi commented Sep 8, 2017

Add tests for CLI #1767

Add tests for CLI #1767

Conversation

Hypnosphi commented Aug 30, 2017 • edited Loading

How to test

Hypnosphi commented Aug 30, 2017

codecov bot commented Aug 30, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

ndelangen commented Aug 30, 2017

Hypnosphi commented Aug 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hypnosphi Sep 8, 2017 • edited Loading

Choose a reason for hiding this comment

Hypnosphi commented Sep 8, 2017

Hypnosphi commented Aug 30, 2017 •

edited

Loading

codecov bot commented Aug 30, 2017 •

edited

Loading

Hypnosphi Sep 8, 2017 •

edited

Loading

Hypnosphi Sep 8, 2017 •

edited

Loading