Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a single version of yarn #19417

Merged
merged 7 commits into from
Oct 10, 2022
Merged

use a single version of yarn #19417

merged 7 commits into from
Oct 10, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 10, 2022 •
edited
Loading

  • I removed the duplicated yarn install and addons
  • I moved the initialization of sb-bench to be outside of the monorepo, because the package.json at the root was conflicting, causing it to not init.

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 10, 2022
@ndelangen ndelangen self-assigned this Oct 10, 2022
yannbf
yannbf approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @ndelangen !

@ndelangen ndelangen mentioned this pull request Oct 10, 2022
Merged
Base automatically changed from tom/sb-628-properly-document-maintenance-scripts to next October 10, 2022 11:02
@ndelangen ndelangen merged commit da3e0f3 into next Oct 10, 2022
@ndelangen ndelangen deleted the norbert/single-version-of-yarn branch October 10, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @yannbf