Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Preact/Webpack templates and update renderer/preset (2) #19451

Merged
merged 3 commits into from Oct 13, 2022
Merged

Add Preact/Webpack templates and update renderer/preset (2) #19451

merged 3 commits into from Oct 13, 2022

Conversation

tmeasday
Copy link
Member

  • Added preact-webpack5/* templates
  • Updated renderer to include components
  • Updated renderer to export render function
  • Updated CLI template to actually work with preset.
  • Updated preset not to clobber docs.

@tmeasday tmeasday added preact build Internal-facing build tooling & test updates labels Oct 12, 2022
@tmeasday tmeasday requested a review from shilman October 12, 2022 02:21
@tmeasday tmeasday mentioned this pull request Oct 12, 2022
Merged
shilman
shilman approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it's intentional that CI is turned off for the preact templates!

@tmeasday tmeasday merged commit c83449f into next Oct 13, 2022
@tmeasday tmeasday deleted the tom/sb-557-typescript-2 branch October 13, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates preact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmeasday @shilman