Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF-tools: Make ESM node compatible #19661

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 28, 2022

Issue: #19533

  • bundle in babel
  • use * as -import
  • configure tsup to build for node

I figured if we change the config & code a bit, and bundle babel in, maybe we can fix this issue easily?

@ndelangen ndelangen self-assigned this Oct 28, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks core csf labels Oct 28, 2022
@ndelangen ndelangen requested a review from IanVS October 28, 2022 07:39
@ndelangen
Copy link
Member Author

@edoardocavazza WDYT? could this be a solution?

@ndelangen ndelangen changed the title make csf-tools ESM node comatible make csf-tools ESM node compatible Oct 28, 2022
@socket-security
Copy link

socket-security bot commented Oct 28, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bin Script Confusion ✅ no new bin script confusions
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@shilman shilman changed the title make csf-tools ESM node compatible CSF-tools: Make ESM node compatible Oct 28, 2022
@ndelangen ndelangen merged commit 3495aba into next Oct 28, 2022
@ndelangen ndelangen deleted the norbert/sb-892-sb19533-bug-mjs-modules-are-bundled branch October 28, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core csf maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant