Core: Remove unnecessary peer deps #20231
Conversation
| @@ -77,11 +77,6 @@ | |||
| "type-fest": "^2.19.0", | |||
| "typescript": "~4.9.3" | |||
| }, | |||
| "peerDependenciesMeta": { | |||
| "typescript": { | |||
There was a problem hiding this comment.
Why is typescript in devDependencies and not dependencies? Does that mean it's being bundled into @storybook/core-common?
There was a problem hiding this comment.
Does that mean it's being bundled into @storybook/core-common?
No, not necessarily, only if the bundler (tsup) would be able to find a dependency chain from any entrypoint to the typescript module. Which if that happened I would find very strange because why would core-common import typescript as a runtime dependency anywhere?
There was a problem hiding this comment.
Right, okay, I keep forgetting that part of things, thanks for being patient with me.
There was a problem hiding this comment.
Why is typescript in devDependencies and not dependencies?
Because if it defined it as a regular dependency, it would also add that module as a dependency for users to install, which I don not think is something we want, right?
Another question would be: "Why is it listed as a devDependency?" to which the answer is:
It's likely isn't, but we do have TS code in the source, so it also makes sense to have it?
TypeScript isn't in the peerDependencies of these packages. |
|
@shilman It's an educated guess of mine but: If this package has a peerDependency on It's just a theory, it could be the packageManager will still traverse up, and find the peerDep is unsatisfied.. I'm guessing the only solution then would be to go into the "offending" package: |
shilman
changed the title
shilman
deleted the
norbert/sb-1087-sb20179-pnpm-missing-typescript-peer
branch
Issue: #20179
What I did
Be confused, as to why we're getting the errors in the issue at all.
But I was able to clean up the peerDeps a bit.