Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix config.base relative paths #20232

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Core: Fix config.base relative paths #20232

merged 1 commit into from
Dec 14, 2022

Conversation

ndelangen
Copy link
Member

Issue: #20138

What I did

I changed the path to begin with ./

@ndelangen ndelangen self-assigned this Dec 13, 2022
@ndelangen ndelangen added the bug label Dec 13, 2022
@ndelangen ndelangen mentioned this pull request Dec 13, 2022
Closed
@ndelangen ndelangen requested a review from IanVS December 13, 2022 17:17
IanVS
IanVS reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be changed in index.ts as well?

router.use(`/sb-preview`, express.static(previewDirOrigin, { immutable: true, maxAge: '5m' }));

@ndelangen
Copy link
Member Author

ndelangen commented Dec 13, 2022 •
edited
Loading

no, that would have no effect @IanVS

Because that's only used when running storybook in dev-mode.

shilman
shilman approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title FIx: #20138 Core: Fix config.base relative paths Dec 14, 2022
@shilman shilman added the core label Dec 14, 2022
@ndelangen ndelangen merged commit ea6054f into next Dec 14, 2022
@ndelangen ndelangen deleted the fix/20138 branch December 14, 2022 07:59
@Terrel007
Copy link

Terrel007 commented Dec 14, 2023 •
edited
Loading

@shilman @ndelangen I found this commit is missing for the next branch.
When I try to run "storybook-build" in my project, the "sb-preview/runtime.js" returns 404 when I it was deployed.
After I patched the "@storybook/builder-vite" package with these changes for my project, and it works fine. So do we still need this commit for the version 7.6.4 or 8.x alpha?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS left review comments

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
bug core
Projects
Core Team Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndelangen @Terrel007 @shilman @IanVS