Update addon-actions peerdependency in nextjs package.json #20324
Conversation
code/frameworks/nextjs/package.json
Outdated
| @@ -87,7 +87,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/core": "^7.11.5", | |||
| "@storybook/addon-actions": "7.0.0-alpha.43", | |||
| "@storybook/addon-actions": "7.0.0-beta.12", | |||
There was a problem hiding this comment.
Let's add a Caret constraint to make the version less strict.
| "@storybook/addon-actions": "7.0.0-beta.12", | |
| "@storybook/addon-actions": "^7.0.0-beta.12", |
There was a problem hiding this comment.
Even tho I'd agree with you, I didn't dare to change it since all the other @storybook dependencies are pointing to that same version :D Is it safe to assume that all those deps should follow the same bumping rules, right? Maybe I should bump them as well in order to avoid recreating the conditions that led to this bug? WDYT?
"@storybook/core-common": "7.0.0-beta.12",
"@storybook/node-logger": "7.0.0-beta.12",
"@storybook/preset-react-webpack": "7.0.0-beta.12",
"@storybook/preview-api": "7.0.0-beta.12",
"@storybook/react": "7.0.0-beta.12",
There was a problem hiding this comment.
These files should be handled by an automation script by @shilman, it seems like it was a hiccup and he's going to update it
There was a problem hiding this comment.
The automation script is a bit brittle -- it looks for the current version & then increments it. I think what happened is that the original PR was already out of sync and so the automation never incremented it properly. I'll merge this & verify that it gets incremented on next release.
There was a problem hiding this comment.
I've updated the release script to deal with ^ versions also per this PR
code/yarn.lock
Outdated
| @@ -6791,7 +6791,7 @@ __metadata: | |||
| webpack: ^5.65.0 | |||
| peerDependencies: | |||
| "@babel/core": ^7.11.5 | |||
| "@storybook/addon-actions": 7.0.0-alpha.43 | |||
| "@storybook/addon-actions": 7.0.0-beta.12 | |||
There was a problem hiding this comment.
| "@storybook/addon-actions": 7.0.0-beta.12 | |
| "@storybook/addon-actions": ^7.0.0-beta.12 |
Issue:
#20323
What I did
I bumped the version of the
@storybook/addon-actionspackage to the latest one in the peerDependencies of nextjspackage.jsonHow to test
If your answer is yes to any of these, please make sure to include it in your PR.