Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: use tsc prep-script for addon storyshots #20523

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Build: use tsc prep-script for addon storyshots #20523

merged 3 commits into from
Jan 6, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 6, 2023 •
edited
Loading

What I did

  • Made storyshots addons use the newly added script for preparing with tsc

In order to do this, I had to move the addons out of their extra nested directory, which IMHO had no real use anyway.

@ndelangen ndelangen self-assigned this Jan 6, 2023
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jan 6, 2023
@ndelangen ndelangen changed the title Norbert/tsc-script-storyshots Build: use tsc prep-script for addon storyshots Jan 6, 2023
@ndelangen ndelangen changed the base branch from next to norbert/tsc-script-for-angular January 6, 2023 16:27
Base automatically changed from norbert/tsc-script-for-angular to next January 6, 2023 18:27
@ndelangen ndelangen mentioned this pull request Jan 6, 2023
Closed
@ndelangen ndelangen merged commit e6ec048 into next Jan 6, 2023
@ndelangen ndelangen deleted the norbert/tsc-script-storyshots branch January 6, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @JReinhold