Vite: Use posix paths for glob #21013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
reviewed
Feb 8, 2023
| @@ -1,4 +1,4 @@ | |||
| import * as path from 'path'; | |||
| import * as posixPath from 'node:path/posix'; // Glob requires forward-slashes | |||
There was a problem hiding this comment.
import { join } from 'node:path/posix';? not sure if it makes a difference in node
There was a problem hiding this comment.
Do you prefer the destructured version? I slightly prefer the namespaced version, just because it's clear when it's being used where it's coming from. posixPath.join() vs just join(). But I don't feel strongly about it and happy to change if you'd like.
There was a problem hiding this comment.
Don't feel strongly. I think @ndelangen was making a push towards the namespaced version (but maybe only in browser code, for tree shaking?), so maybe he can comment here.
shilman
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes storybookjs/builder-vite#554
What I did
New vite projects are failing in Windows because of a change in an updated
globpackage which enforces forward-slashes for glob paths.So, we'll use
path.posixto join paths in the vite builder for globs.How to test
I don't have access to a windows box, so I'm not able to test. And we don't test Windows in CI. I'm hoping that maybe @joshwooding or someone else can help test this out.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]