Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Allow ArgTable usage unattached #21371

Merged
merged 7 commits into from Mar 5, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 3, 2023

Closes #21366

What I did

Rework legacy ArgsTable to work even if storyById() throws (unattached).

How to test

  1. yarn task --task dev --template lit-vite/default-ts
  2. Add <ArgsTable of="button" /> to Introduction.mdx
  3. Visit http://localhost:6006/?path=/docs/example-introduction--docs

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday marked this pull request as ready for review March 3, 2023 06:20
@tmeasday
Copy link
Member Author

tmeasday commented Mar 3, 2023

@shilman I think this code is theoretically right, but I am getting (with the instructions above):

image

I'm pretty sure that makes sense because "button" is not a reference to a component 🤷

@shilman
Copy link
Member

shilman commented Mar 3, 2023

@tmeasday You can use the component demo-wc-card and it's working

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmeasday tmeasday merged commit 29a33ed into next Mar 5, 2023
@tmeasday tmeasday deleted the tom/21366-fix-unattached-argsTable branch March 5, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ArgsTable does not work unattached
3 participants