Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Print errors in withTelemetry before prompting #21407

Merged
merged 3 commits into from Mar 6, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 6, 2023

Closes #21310

What I did

  • Print errors in withTelemetry allow configuring formatting.
  • Also always exit(1) in generate.ts
  • Note previously upgrade didn't print errors or exit(1). This is a change I could undo.

image

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Also make exiting more consistent across commands. For #21373
@tmeasday tmeasday requested a review from shilman March 6, 2023 06:07
@shilman shilman changed the title Core: Print errors in withTelemetry, before prompting Core: Print errors in withTelemetry before prompting Mar 6, 2023
Also ensure errors thrown from dev process are sent via telemetry
@shilman shilman merged commit bf3fd36 into next Mar 6, 2023
@shilman shilman deleted the 21310-show-error-telemetry branch March 6, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Fix telemetry prompt to show after error display
3 participants