Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codemod dependency conflict #21876

Merged
merged 2 commits into from Apr 3, 2023
Merged

Fix codemod dependency conflict #21876

merged 2 commits into from Apr 3, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Apr 2, 2023 •
edited

Closes #

local sandboxes are broken , dependency conflict for @babel/preset-env.

What I did

fix dependency conflicts by upgrading @babel/preset-env. to match babel core version in @storybook/codemod

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@chakAs3 chakAs3 added build Internal-facing build tooling & test updates codemods labels Apr 2, 2023
shilman
shilman approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakAs3 chakAs3 mentioned this pull request Apr 3, 2023
Closed
5 tasks
@JReinhold JReinhold changed the title Chaks/fix codemod deps issue Fix codemod dependency conflict Apr 3, 2023
@JReinhold
Copy link
Contributor

Thanks for this @chakAs3 <3

@JReinhold JReinhold merged commit 4f2142d into next Apr 3, 2023
69 checks passed
@JReinhold JReinhold deleted the chaks/fix-codemod-deps-issue branch April 3, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates codemods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chakAs3 @JReinhold @shilman