Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Include decorators by default in source decorators #21902

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 4, 2023

Closes #21900

What I did

Partially reverted #21722. There were some other fixes in there that I didn't touch.

We set docs.source.excludeDecorators to true in order to avoid #21649 (not fix it).

However, this completely breaks Storybook in the case when the story requires a decorator to be present, as is the case with the repro in #21900.

We'll need to come up with a proper fix to #21649.

How to test

See repro in #21900

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 5, 2023
@shilman shilman merged commit 05cb5d5 into next Apr 5, 2023
@shilman shilman deleted the shilman/21900-revert-source-exclude-decorators branch April 5, 2023 12:53
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman added a commit that referenced this pull request Apr 6, 2023
…e-exclude-decorators

Addon-docs: Include decorators by default in source decorators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs block: source bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 7.0.0-rc.9 Decorators are broken in custom render components
1 participant