Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Pass parameters in SET_INDEX for docs entries #22154

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Apr 19, 2023

Closes #21798 for SSv6

What I did

Include parameters in the (v6) SET_STORIES event.

How to test

See E2E spec.

In a ssv6 sandbox, visit:

And check the backgrounds toolbar item.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested review from shilman and yannbf April 19, 2023 05:50
@tmeasday tmeasday added the ci:merged Run the CI jobs that normally run when merged. label Apr 19, 2023
@tmeasday tmeasday added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 19, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the fact that the addon-backgrounds toolbar makes no sense (currently, at least) in unattached docs when there are no stories.

Also, could you check the Chromatic diffs?

@tmeasday tmeasday merged commit abc2350 into next Apr 19, 2023
@tmeasday tmeasday deleted the tom/21798-set-docs-parameters-in-index branch April 19, 2023 11:02
shilman pushed a commit that referenced this pull request Apr 24, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug ci:merged Run the CI jobs that normally run when merged. core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useParameter() returns nothing for a docs page
3 participants