Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out flaky test #22310

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Comment out flaky test #22310

merged 2 commits into from
Apr 28, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Apr 28, 2023
@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label Apr 28, 2023
@valentinpalkovic valentinpalkovic merged commit 68c2444 into next Apr 28, 2023
23 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/remove-flaky-test branch April 28, 2023 15:20
@shilman
Copy link
Member

shilman commented May 3, 2023

@valentinpalkovic does this need to be patched back to main?

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 3, 2023
@valentinpalkovic
Copy link
Contributor Author

Potentially, to avoid flakiness on main

@shilman
Copy link
Member

shilman commented May 5, 2023

This test wasn't on main, so won't patch

@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants