Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Migrate @storybook/csf-tools to strict TS #22312

Merged
merged 4 commits into from
May 1, 2023

Conversation

usrrname
Copy link
Contributor

Part of #22176

What I did

  1. Ensure I'm using node 16
  2. Ran yarn task --task compile --no-link --start-from=install
  3. Change tsconfig.json compilerOptions.strict to true
  4. Ran yarn check inside code/lib/csf-tools
  5. Fix VSCode linter errors in 640c4a3 and af26a45
  6. Fix yarn check errors

How to test

  1. Ran yarn check inside code/lib/csf-tools
  2. from storybook/, ran yarn run test getStorySortParameter.test.ts and yarn run test ConfigFile.test.ts to ensure tests are passing

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@usrrname usrrname force-pushed the 22176-csf-tools-strict-ts branch 3 times, most recently from 4266e28 to 1f063be Compare April 30, 2023 14:46
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label May 1, 2023
@kasperpeulen kasperpeulen requested a review from shilman May 1, 2023 14:12
@kasperpeulen
Copy link
Contributor

LGTM, maybe @shilman can have one more look

@usrrname
Copy link
Contributor Author

usrrname commented May 1, 2023

I used ChatGPT to explain what the codeblocks were doing 😆
also, I learned that babel/parser exists! nice

@usrrname usrrname force-pushed the 22176-csf-tools-strict-ts branch from 50b6942 to ef5206b Compare May 1, 2023 14:52
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks so much @usrrname !!! 🙏

@shilman shilman added maintenance User-facing maintenance tasks typescript and removed build Internal-facing build tooling & test updates labels May 1, 2023
@shilman shilman changed the title Build: Migrate @storybook/csf-tools to strict TS Typescript: Migrate @storybook/csf-tools to strict TS May 1, 2023
@shilman shilman merged commit f0af303 into storybookjs:next May 1, 2023
@usrrname usrrname deleted the 22176-csf-tools-strict-ts branch May 1, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants