Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on YN0060 - INCOMPATIBLE_PEER_DEPENDENCY #22398

Merged
merged 2 commits into from Jun 1, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Some package managers throw an error if peer dependencies are not met properly. Yarn, though, just logs a warning. It would be nice if our sandboxes fail if peer dependencies are not met. Therefore, yarn now fails for YN0060 - INCOMPATIBLE_PEER_DEPENDENCY instead of just returning back a warning.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label May 4, 2023
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label May 4, 2023
@ndelangen
Copy link
Member

Can we somehow version-lock the package svelte-check for our sandboxes?

@socket-security
Copy link

socket-security bot commented May 5, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

@valentinpalkovic
Copy link
Contributor Author

valentinpalkovic commented May 5, 2023

Currently waiting for vitejs/vite#13103 being released

@valentinpalkovic valentinpalkovic self-assigned this May 8, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yannbf yannbf added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels May 8, 2023
@valentinpalkovic valentinpalkovic merged commit 3e32fc6 into next Jun 1, 2023
99 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/error-on-yn0060 branch June 1, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants